adamsaghy commented on code in PR #4347:
URL: https://github.com/apache/fineract/pull/4347#discussion_r1969464962
##########
fineract-rates/src/main/java/org/apache/fineract/portfolio/floatingrates/api/FloatingRatesApiResource.java:
##########
@@ -92,11 +90,11 @@ public String createFloatingRate(@Parameter(hidden = true)
final String apiReque
@Operation(summary = "List Floating Rates", description = "Lists Floating
Rates")
@ApiResponses({
@ApiResponse(responseCode = "200", description = "OK", content =
@Content(array = @ArraySchema(schema = @Schema(implementation =
FloatingRatesApiResourceSwagger.GetFloatingRatesResponse.class)))) })
- public String retrieveAll(@Context final UriInfo uriInfo) {
+ public List<FloatingRateResponse> retrieveAll() {
this.context.authenticatedUser().validateHasReadPermission(RESOURCE_NAME);
final List<FloatingRateData> floatingRates =
this.floatingRatesReadPlatformService.retrieveAll();
- final ApiRequestJsonSerializationSettings settings =
this.apiRequestParameterHelper.process(uriInfo.getQueryParameters());
- return this.toApiJsonSerializer.serialize(settings, floatingRates,
FloatingRatesApiResource.LIST_FLOATING_RATES_PARAMETERS);
+ return floatingRates.stream().map(data -> new
FloatingRateResponse(data.getId(), data.getName(), data.isBaseLendingRate(),
Review Comment:
API should not remap the service response. Would you mind to revisit this
logic and make sure the service provides the wanted response immediately?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
