VictorPavfurious commented on code in PR #4353:
URL: https://github.com/apache/fineract/pull/4353#discussion_r1967653831
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/api/SmsApiResource.java:
##########
@@ -64,79 +64,57 @@ public class SmsApiResource {
private final PlatformSecurityContext context;
private final SmsReadPlatformService readPlatformService;
- private final DefaultToApiJsonSerializer<SmsData> toApiJsonSerializer;
- private final ApiRequestParameterHelper apiRequestParameterHelper;
private final PortfolioCommandSourceWritePlatformService
commandsSourceWritePlatformService;
- private final SqlValidator sqlValidator;
+ private final DefaultToApiJsonSerializer<String> apiJsonSerializer;
@GET
- public String retrieveAll(@Context final UriInfo uriInfo) {
+ public Collection<SmsData> retrieveAll() {
Review Comment:
Yes, you are right, better use List
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
