VictorPavfurious commented on code in PR #4353:
URL: https://github.com/apache/fineract/pull/4353#discussion_r1967963137
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/service/SmsReadPlatformServiceImpl.java:
##########
@@ -200,6 +199,9 @@ public Collection<SmsData> retrieveAllFailed(final Integer
limit) {
@Override
public Page<SmsData> retrieveSmsByStatus(final Long campaignId, final
SearchParameters searchParameters, final Integer status,
final LocalDate dateFrom, final LocalDate dateTo) {
+ sqlValidator.validate(searchParameters.getOrderBy());
Review Comment:
@adamsaghy It is a not newly validations, i just have moved this
validations from API controller to services layers. In the best practice, I
think controllers layer should fetch data from a services for more clear..
So, do you think need to some tests for these ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
