adamsaghy commented on code in PR #4382:
URL: https://github.com/apache/fineract/pull/4382#discussion_r1971592298
##########
fineract-branch/src/main/java/org/apache/fineract/organisation/teller/domain/Cashier.java:
##########
@@ -140,19 +132,15 @@ public Map<String, Object> update(final JsonCommand
command) {
this.endDate =
command.localDateValueOfParameterNamed(endDateParamName);
}
- final Boolean isFullDay =
command.booleanObjectValueOfParameterNamed("isFullDay");
+ final boolean fullDayFlag =
command.booleanPrimitiveValueOfParameterNamed(IS_FULL_DAY_PARAM_NAME);
Review Comment:
Changing from Boolean to boolean is changing the behaviour as from 3
options(true, false, null), now it became just 2 (true, false).
`isFullDay` is a nullable field in a the `m_cashiers` table, so this change
is breaking change!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
