7ossam7atem1 commented on code in PR #4382:
URL: https://github.com/apache/fineract/pull/4382#discussion_r1971670047
##########
fineract-branch/src/main/java/org/apache/fineract/organisation/teller/domain/Cashier.java:
##########
@@ -140,19 +132,15 @@ public Map<String, Object> update(final JsonCommand
command) {
this.endDate =
command.localDateValueOfParameterNamed(endDateParamName);
}
- final Boolean isFullDay =
command.booleanObjectValueOfParameterNamed("isFullDay");
+ final boolean fullDayFlag =
command.booleanPrimitiveValueOfParameterNamed(IS_FULL_DAY_PARAM_NAME);
Review Comment:
> Changing from Boolean to boolean is changing the behaviour as from 3
options(true, false, null), now it became just 2 (true, false).
>
> `isFullDay` is a nullable field in a the `m_cashiers` table, so this
change is breaking change, no?
Ah, you're right
The nullable aspect of the `isFullDay` field in `m_cashiers` is pretty
important here. Moving from Boolean to boolean would definitely break things
since we'd lose the null state option by forcing it to only 2 states (true,
false).
I'll roll back that part of the change and stick to the safer improvements,
Thanks for the thorough review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
