oleksii-novikov-onix commented on code in PR #4384:
URL: https://github.com/apache/fineract/pull/4384#discussion_r1972072010
##########
fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/stepdef/loan/LoanStepDef.java:
##########
@@ -2007,10 +2007,11 @@ private List<List<String>>
getActualValuesList(List<GetLoansLoanIdLoanChargeData
actualValues.add(t.getChargeTimeType().getValue() == null ? null :
t.getChargeTimeType().getValue());
actualValues.add(t.getDueDate() == null ? null :
FORMATTER.format(t.getDueDate()));
actualValues.add(t.getChargeCalculationType().getValue() == null ?
null : t.getChargeCalculationType().getValue());
- actualValues.add(t.getAmount() == null ? null :
String.valueOf(t.getAmount()));
+ actualValues.add(t.getAmount() == null ? null : String.valueOf(new
Utils.DoubleFormatter(t.getAmount()).format()));
actualValues.add(t.getAmountPaid() == null ? null :
String.valueOf(t.getAmountPaid()));
actualValues.add(t.getAmountWaived() == null ? null :
String.valueOf(t.getAmountWaived()));
- actualValues.add(t.getAmountOutstanding() == null ? null :
String.valueOf(t.getAmountOutstanding()));
+ actualValues.add(
+ t.getAmountOutstanding() == null ? null :
String.valueOf(new Utils.DoubleFormatter(t.getAmountOutstanding()).format()));
Review Comment:
The same here, we can remove the additional invocation of String.valueOf(),
as DoubleFormatter.format already returns a string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
