oleksii-novikov-onix commented on code in PR #4384:
URL: https://github.com/apache/fineract/pull/4384#discussion_r1972074619
##########
fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/stepdef/loan/LoanStepDef.java:
##########
@@ -3203,12 +3205,12 @@ private List<String>
fetchValuesOfRepaymentSchedule(List<String> header, GetLoan
actualValues.add(repaymentPeriod.getPrincipalDue() == null
? null : String.valueOf(repaymentPeriod.getPrincipalDue()));
case "Interest" ->
actualValues.add(repaymentPeriod.getInterestDue() == null
? null : String.valueOf(repaymentPeriod.getInterestDue()));
- case "Fees" -> actualValues
- .add(repaymentPeriod.getFeeChargesDue() == null ? null
: String.valueOf(repaymentPeriod.getFeeChargesDue()));
- case "Penalties" -> actualValues.add(
- repaymentPeriod.getPenaltyChargesDue() == null ? null
: String.valueOf(repaymentPeriod.getPenaltyChargesDue()));
- case "Due" -> actualValues.add(
- repaymentPeriod.getTotalDueForPeriod() == null ? null
: String.valueOf(repaymentPeriod.getTotalDueForPeriod()));
+ case "Fees" ->
actualValues.add(repaymentPeriod.getFeeChargesDue() == null ? null
+ : String.valueOf(new
Utils.DoubleFormatter(repaymentPeriod.getFeeChargesDue()).format()));
+ case "Penalties" ->
actualValues.add(repaymentPeriod.getPenaltyChargesDue() == null ? null
+ : String.valueOf(new
Utils.DoubleFormatter(repaymentPeriod.getPenaltyChargesDue()).format()));
Review Comment:
Unnecessary String.valueOf() call
##########
fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/stepdef/loan/LoanStepDef.java:
##########
@@ -3203,12 +3205,12 @@ private List<String>
fetchValuesOfRepaymentSchedule(List<String> header, GetLoan
actualValues.add(repaymentPeriod.getPrincipalDue() == null
? null : String.valueOf(repaymentPeriod.getPrincipalDue()));
case "Interest" ->
actualValues.add(repaymentPeriod.getInterestDue() == null
? null : String.valueOf(repaymentPeriod.getInterestDue()));
- case "Fees" -> actualValues
- .add(repaymentPeriod.getFeeChargesDue() == null ? null
: String.valueOf(repaymentPeriod.getFeeChargesDue()));
- case "Penalties" -> actualValues.add(
- repaymentPeriod.getPenaltyChargesDue() == null ? null
: String.valueOf(repaymentPeriod.getPenaltyChargesDue()));
- case "Due" -> actualValues.add(
- repaymentPeriod.getTotalDueForPeriod() == null ? null
: String.valueOf(repaymentPeriod.getTotalDueForPeriod()));
+ case "Fees" ->
actualValues.add(repaymentPeriod.getFeeChargesDue() == null ? null
+ : String.valueOf(new
Utils.DoubleFormatter(repaymentPeriod.getFeeChargesDue()).format()));
+ case "Penalties" ->
actualValues.add(repaymentPeriod.getPenaltyChargesDue() == null ? null
+ : String.valueOf(new
Utils.DoubleFormatter(repaymentPeriod.getPenaltyChargesDue()).format()));
+ case "Due" ->
actualValues.add(repaymentPeriod.getTotalDueForPeriod() == null ? null
+ : String.valueOf(new
Utils.DoubleFormatter(repaymentPeriod.getTotalDueForPeriod()).format()));
Review Comment:
Unnecessary String.valueOf() call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
