7ossam7atem1 commented on code in PR #4389:
URL: https://github.com/apache/fineract/pull/4389#discussion_r1973238623
##########
fineract-provider/src/test/java/org/apache/fineract/infrastructure/event/business/domain/BulkBusinessEventTest.java:
##########
@@ -31,34 +31,46 @@
class BulkBusinessEventTest {
@Test
- public void testConstructorWorksForSameAggregateId() {
Review Comment:
> is there a reason to remove public visibility?
removal of 'public' modifier follows JUnit 5's design principles:
1. Unlike JUnit 4, JUnit 5 doesn't require test methods to be public
2. Since test methods are only called within their own test class,
package-private visibility is sufficient
3. This follows the principle of least privilege - using the most
restrictive access level possible
Would you prefer to keep the public modifier for consistency with existing
codebase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
