7ossam7atem1 commented on code in PR #4389:
URL: https://github.com/apache/fineract/pull/4389#discussion_r1973263668
##########
fineract-provider/src/test/java/org/apache/fineract/infrastructure/event/business/domain/BulkBusinessEventTest.java:
##########
@@ -31,34 +31,46 @@
class BulkBusinessEventTest {
@Test
- public void testConstructorWorksForSameAggregateId() {
Review Comment:
> Just because they are not required to be public, it does not mean it has
any additional value to change them...
You're right! While JUnit 5 makes them optional, removing the public
modifiers doesn't add any real value here, it's just a style preference. Let me
know if you want me to revert the change to maintain consistency with the
existing codebase.
Thank you for the detailed reviews, I'm learning a lot from them!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
