adamsaghy commented on code in PR #4435:
URL: https://github.com/apache/fineract/pull/4435#discussion_r1987683291
##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/rule/api/AccountingRuleApiResource.java:
##########
@@ -196,15 +173,13 @@ public String createAccountingRule(@Parameter(hidden =
true) final String jsonRe
@RequestBody(content = @Content(schema = @Schema(implementation =
AccountingRuleApiResourceSwagger.PutAccountingRulesRequest.class)))
@ApiResponses({
@ApiResponse(responseCode = "200", description = "OK", content =
@Content(schema = @Schema(implementation =
AccountingRuleApiResourceSwagger.PutAccountingRulesResponse.class))) })
Review Comment:
Kindly validate whether the `CommandProcessingResult` and
`AccountingRuleApiResourceSwagger.PutAccountingRulesResponse` fields are
matching!
We can consider removing the annotation and the explicit swagger class if it
is not matching!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
