adamsaghy commented on code in PR #4435:
URL: https://github.com/apache/fineract/pull/4435#discussion_r1987681493
##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/rule/api/AccountingRuleApiResource.java:
##########
@@ -105,15 +106,9 @@ public class AccountingRuleApiResource {
+ "\n" + "Field Defaults\n" + "Allowed Value Lists\n" + "Example
Request:\n" + "\n" + "accountingrules/template")
@ApiResponses({
@ApiResponse(responseCode = "200", description = "OK", content =
@Content(schema = @Schema(implementation =
AccountingRuleApiResourceSwagger.GetAccountRulesTemplateResponse.class))) })
Review Comment:
You might wanna remove the Swagger response annotation here as the
`AccountingRuleApiResourceSwagger.GetAccountRulesTemplateResponse` contains
only a couple of the fields that are retrieved... Without the annotation it
will generate the swagger response based on the return data type which is
better in this case!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
