adamsaghy commented on code in PR #4433:
URL: https://github.com/apache/fineract/pull/4433#discussion_r1987667352
##########
fineract-core/src/main/java/org/apache/fineract/useradministration/domain/AppUser.java:
##########
@@ -226,26 +242,6 @@ public Map<String, Object> update(final JsonCommand
command, final PlatformPassw
final Map<String, Object> actualChanges = new LinkedHashMap<>(7);
- // unencoded password provided
Review Comment:
So basically you are about to split into two the user update and change
password actions, right?
I wonder whether this should be first announce in the Fineract DEV mail list
and maybe do it in 2 steps:
- Create the new endpoint to change password
- Announce and marking the charging password option as part of the user
update as deprecated
I think any breaking change (like this) should be announced and discussed in
advance in the Fineract DEV mail list and probably we should provide some time
to anybody to do the required changes at their side + the UI projects!
**I would not remove the option to update the password via the update user
endpoint for now!**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
