adamsaghy commented on code in PR #4542:
URL: https://github.com/apache/fineract/pull/4542#discussion_r2033379454


##########
fineract-core/src/main/java/org/apache/fineract/useradministration/domain/AppUser.java:
##########
@@ -195,6 +197,26 @@ public EnumOptionData organisationalRoleData() {
         return organisationalRole;
     }
 
+    public Map<String, Object> changePassword(final JsonCommand command, final 
PlatformPasswordEncoder platformPasswordEncoder) {
+        // unencoded password provided
+        final Map<String, Object> actualChanges = new LinkedHashMap<>(1);
+        updatePassword(command, platformPasswordEncoder, actualChanges);
+        return actualChanges;
+    }
+
+    private void updatePassword(JsonCommand command, PlatformPasswordEncoder 
platformPasswordEncoder, Map<String, Object> actualChanges) {
+        final String passwordParamName = PASSWORD;
+        final String passwordEncodedParamName = "passwordEncoded";
+        if (command.hasParameter(passwordParamName)) {
+            if (command.isChangeInPasswordParameterNamed(passwordParamName, 
this.password, platformPasswordEncoder, getId())) {
+                final String passwordEncodedValue = 
command.passwordValueOfParameterNamed(passwordParamName, 
platformPasswordEncoder,
+                        getId());
+                actualChanges.put(passwordEncodedParamName, 
passwordEncodedValue);

Review Comment:
   Do not send back the encoded password!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to