adamsaghy commented on code in PR #4510:
URL: https://github.com/apache/fineract/pull/4510#discussion_r2026625527
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/loan/LoanImportHandler.java:
##########
@@ -124,17 +124,20 @@ private DisbursementData readDisbursalData(final Row row,
final String locale, f
if (ImportHandlerUtils.readAsLong(LoanConstants.LINK_ACCOUNT_ID, row)
!= null) {
linkAccountId =
Objects.requireNonNull(ImportHandlerUtils.readAsLong(LoanConstants.LINK_ACCOUNT_ID,
row)).toString();
}
-
if (disbursedDate != null) {
+
Review Comment:
Please remove empty lines...
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/loan/LoanImportHandler.java:
##########
@@ -124,17 +124,20 @@ private DisbursementData readDisbursalData(final Row row,
final String locale, f
if (ImportHandlerUtils.readAsLong(LoanConstants.LINK_ACCOUNT_ID, row)
!= null) {
linkAccountId =
Objects.requireNonNull(ImportHandlerUtils.readAsLong(LoanConstants.LINK_ACCOUNT_ID,
row)).toString();
}
-
if (disbursedDate != null) {
+
return DisbursementData.importInstance(disbursedDate,
linkAccountId, row.getRowNum(), locale, dateFormat);
+
}
return null;
}
private LoanApprovalData readLoanApproval(final Row row, final String
locale, final String dateFormat) {
LocalDate approvedDate =
ImportHandlerUtils.readAsDate(LoanConstants.APPROVED_DATE_COL, row);
if (approvedDate != null) {
+
Review Comment:
Please remove empty lines...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
