adamsaghy commented on code in PR #4510:
URL: https://github.com/apache/fineract/pull/4510#discussion_r2026635362


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookPopulatorServiceImpl.java:
##########
@@ -489,7 +489,7 @@ private WorkbookPopulator populateGuarantorWorkbook(Long 
officeId) {
     private List<SavingsAccountData> fetchSavingsAccounts(Long officeId) {
         List<SavingsAccountData> savingsAccounts = null;
         if (officeId != null) {
-            SearchParameters searchParameters = 
SearchParameters.builder().officeId(officeId).status("300").build();

Review Comment:
   Filtering to status 300 was a mistake?



##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookPopulatorServiceImpl.java:
##########
@@ -489,7 +489,7 @@ private WorkbookPopulator populateGuarantorWorkbook(Long 
officeId) {
     private List<SavingsAccountData> fetchSavingsAccounts(Long officeId) {
         List<SavingsAccountData> savingsAccounts = null;
         if (officeId != null) {
-            SearchParameters searchParameters = 
SearchParameters.builder().officeId(officeId).status("300").build();

Review Comment:
   Filtering to status 300 was a bug?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to