oleksii-novikov-onix commented on code in PR #4552:
URL: https://github.com/apache/fineract/pull/4552#discussion_r2034118145


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanChargeWritePlatformServiceImpl.java:
##########
@@ -305,7 +306,7 @@ public CommandProcessingResult addLoanCharge(final Long 
loanId, final JsonComman
             } else {
                 reprocessLoanTransactionsService.reprocessTransactions(loan);
             }
-            loan.doPostLoanTransactionChecks(transactionDate, 
loan.getLoanLifecycleStateMachine());
+            defaultLoanLifecycleStateMachine.doPostLoanTransactionChecks(loan, 
transactionDate);

Review Comment:
   Yes, Adam, as an improvement, I added context-specific methods to 
LoanLifecycleStateMachine. Please recheck my additional commit. I haven’t 
squashed yet to make it easier to track my changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to