oleksii-novikov-onix commented on code in PR #4552:
URL: https://github.com/apache/fineract/pull/4552#discussion_r2052775024
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -3097,7 +3091,7 @@ public void handleChargebackTransaction(final Loan loan,
LoanTransaction chargeb
new MoneyHolder(loan.getTotalOverpaidAsMoney()),
null));
}
loan.updateLoanSummaryDerivedFields();
- if
(!loan.doPostLoanTransactionChecks(chargebackTransaction.getTransactionDate(),
loanLifecycleStateMachine)) {
+ if (!loanLifecycleStateMachine.doPostLoanTransactionChecks(loan,
chargebackTransaction.getTransactionDate())) {
Review Comment:
Replaced the boolean-returning doPostLoanTransactionChecks with a more
explicit method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
