adamsaghy commented on code in PR #4614:
URL: https://github.com/apache/fineract/pull/4614#discussion_r2055758999


##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingHelper.java:
##########
@@ -100,6 +100,8 @@ public void mergeProductToAccountMappingChanges(final 
JsonElement element, final
                 
optionalProductToGLAccountMappingEntries.add("incomeFromGoodwillCreditInterestAccountId");
                 
optionalProductToGLAccountMappingEntries.add("incomeFromGoodwillCreditFeesAccountId");
                 
optionalProductToGLAccountMappingEntries.add("incomeFromGoodwillCreditPenaltyAccountId");
+                
optionalProductToGLAccountMappingEntries.add("deferredIncomeLiabilityAccountId");
+                
optionalProductToGLAccountMappingEntries.add("incomeFromDeferredIncomeAccountId");

Review Comment:
   We only need deferred income GL account which is liability.
   The `incomeFromDeferredIncomeAccountId` where it is coming from?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to