magyari-adam commented on code in PR #4614:
URL: https://github.com/apache/fineract/pull/4614#discussion_r2058137945
##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingHelper.java:
##########
@@ -100,6 +100,8 @@ public void mergeProductToAccountMappingChanges(final
JsonElement element, final
optionalProductToGLAccountMappingEntries.add("incomeFromGoodwillCreditInterestAccountId");
optionalProductToGLAccountMappingEntries.add("incomeFromGoodwillCreditFeesAccountId");
optionalProductToGLAccountMappingEntries.add("incomeFromGoodwillCreditPenaltyAccountId");
+
optionalProductToGLAccountMappingEntries.add("deferredIncomeLiabilityAccountId");
+
optionalProductToGLAccountMappingEntries.add("incomeFromDeferredIncomeAccountId");
Review Comment:
Renamed it.
##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingReadPlatformServiceImpl.java:
##########
@@ -167,6 +167,10 @@ public Map<String, Object>
fetchAccountMappingDetailsForLoanProduct(final Long l
} else if
(glAccountForLoan.equals(AccrualAccountsForLoan.INCOME_FROM_GOODWILL_CREDIT_PENALTY))
{
accountMappingDetails.put(LoanProductAccountingDataParams.INCOME_FROM_GOODWILL_CREDIT_PENALTY.getValue(),
gLAccountData);
+ } else if
(glAccountForLoan.equals(AccrualAccountsForLoan.DEFERRED_INCOME_LIABILITY)) {
+
accountMappingDetails.put(LoanProductAccountingDataParams.DEFERRED_INCOME_LIABILITY.getValue(),
gLAccountData);
+ } else if
(glAccountForLoan.equals(AccrualAccountsForLoan.INCOME_FROM_DEFERRED_INCOME)) {
+
accountMappingDetails.put(LoanProductAccountingDataParams.INCOME_FROM_DEFERRED_INCOME.getValue(),
gLAccountData);
Review Comment:
Renamed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
