adamsaghy commented on code in PR #4651:
URL: https://github.com/apache/fineract/pull/4651#discussion_r2081485163
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java:
##########
@@ -1399,23 +1426,70 @@ public LoanScheduleData extractData(@NotNull final
ResultSet rs) throws SQLExcep
totalPaidLate.getAmount(), totalOutstanding.getAmount(),
totalCredits.getAmount());
}
- private BigDecimal processDisbursementData(LoanScheduleType
loanScheduleType, Collection<DisbursementData> disbursementData,
- LocalDate fromDate, LocalDate dueDate, Set<Long>
disbursementPeriodIds, BigDecimal disbursementChargeAmount,
- BigDecimal waivedChargeAmount, List<LoanSchedulePeriodData>
periods) {
+ private BigDecimal
processDisbursementAndCapitalizedIncomeData(LoanScheduleType loanScheduleType,
Review Comment:
Please make distinction between disbursement and capitalized income! We
should not merge them together!
Disbursement amount shall NOT include capitalized income!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
