adamsaghy commented on code in PR #4651:
URL: https://github.com/apache/fineract/pull/4651#discussion_r2095849740
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanSummary.java:
##########
@@ -225,7 +238,7 @@ public void updateSummary(final MonetaryCurrency currency,
final Money principal
this.totalPenaltyChargesOutstanding =
totalPenaltyChargesCharged.minus(this.totalPenaltyChargesRepaid)
.minus(this.totalPenaltyChargesWaived).minus(this.totalPenaltyChargesWrittenOff).getAmount();
- final Money totalExpectedRepayment = Money.of(currency,
this.totalPrincipalDisbursed).plus(this.totalInterestCharged)
+ final Money totalExpectedRepayment = Money.of(currency,
this.totalPrincipalOutstanding).plus(this.totalInterestCharged)
Review Comment:
This looks incorrect... outstanding always changing, but total expected
repayment does not....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
