adamsaghy commented on code in PR #4828:
URL: https://github.com/apache/fineract/pull/4828#discussion_r2180484866


##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/exceptionmapper/PlatformDomainRuleExceptionMapper.java:
##########
@@ -46,8 +47,14 @@ public class PlatformDomainRuleExceptionMapper implements 
FineractExceptionMappe
     @Override
     public Response toResponse(final AbstractPlatformDomainRuleException 
exception) {
         log.warn("Exception occurred", 
ErrorHandler.findMostSpecificException(exception));
-        final ApiGlobalErrorResponse notFoundErrorResponse = 
ApiGlobalErrorResponse.domainRuleViolation(
-                exception.getGlobalisationMessageCode(), 
exception.getDefaultUserMessage(), exception.getDefaultUserMessageArgs());
+        final ApiGlobalErrorResponse notFoundErrorResponse;

Review Comment:
   PlatformApiDomainRuleValidationException is mapped HTTP 403 exception for 
domain rule violations
   PlatformApiDataValidationException is mapped to HTTP 400 exception for 
request data validation violations



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to