adamsaghy commented on code in PR #4828:
URL: https://github.com/apache/fineract/pull/4828#discussion_r2210149139
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanDisbursementValidator.java:
##########
@@ -44,8 +44,8 @@ public void
compareDisbursedToApprovedOrProposedPrincipal(final Loan loan, final
} else {
if ((totalDisbursed.compareTo(loan.getApprovedPrincipal()) > 0)
||
(totalDisbursed.add(capitalizedIncome).compareTo(loan.getApprovedPrincipal()) >
0)) {
- final String errorMsg = "Loan can't be disbursed,disburse
amount is exceeding approved principal ";
- throw new LoanDisbursalException(errorMsg,
"disburse.amount.must.be.less.than.approved.principal", totalDisbursed,
+ final String errorMsg = "Loan can't be disbursed, disburse
amount is exceeding proposed principal.";
Review Comment:
Since we were checking the `approved amount` i think we should not change
the exception message!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
