adamsaghy commented on PR #4837:
URL: https://github.com/apache/fineract/pull/4837#issuecomment-3045872697
@sayhaed Checks are failing:
```
(see https://errorprone.info/bugpattern/StringCaseLocaleUsage)
Did you mean
'StringUtils.capitalize(accountType.toString().toLowerCase(Locale.ROOT)) + "
account with identifier " + id + " does not exist", id, e);' or
'StringUtils.capitalize(accountType.toString().toLowerCase(Locale.getDefault()))
+ " account with identifier " + id + " does not exist", id, e);' or
'StringUtils.capitalize(Ascii.toLowerCase(accountType.toString())) + " account
with identifier " + id + " does not exist", id, e);'?
/home/runner/work/fineract/fineract/fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsProductAssembler.java:21:
error: [WildcardImport] Wildcard imports, static or otherwise, should not be
used
import static org.apache.fineract.portfolio.savings.SavingsApiConstants.*;
^
(see
https://google.github.io/styleguide/javaguide.html?cl=head#s3.3.1-wildcard-imports)
/home/runner/work/fineract/fineract/fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsSchedularInterestPoster.java:29:
error: [WildcardImport] Wildcard imports, static or otherwise, should not be
used
import java.util.*;
^
* What went wrong:
Execution failed for task ':fineract-savings:compileJava'.
> Compilation failed; see the compiler error output for details.
```
https://issues.apache.org/jira/browse/FINERACT-2312 is completely empty!
Neither the story nor the PR explains what are the changes, what the basis
of the calculation, how it works, etc....
Please make sure the story reflects:
- the intended changes
- the business logic, the calculations, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
