adamsaghy commented on PR #4837:
URL: https://github.com/apache/fineract/pull/4837#issuecomment-3050514820

   > Hi @adamsaghy We are getting errors in the GitHub Actions but they are not 
related to the changes that we have sent in the PR. Could you please help us to 
understand which must be fixed in order to pass the testing.
   
   Usually it relates to :)
   
   Let me give you the list of issues:
   
   ```
       (see https://errorprone.info/bugpattern/NotJavadoc)
     Did you mean '/*'?
   
/home/runner/work/fineract/fineract/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsAccrualWritePlatformServiceImpl.java:111:
 error: [ModifiedButNotUsed] A collection or proto builder was created, but its 
values were never accessed.
           List<Throwable> errors = new ArrayList<>();
   ```
   
   ```
       (see https://errorprone.info/bugpattern/HidingField)
   
/home/runner/work/fineract/fineract/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/RecurringDepositAccount.java:1156:
 error: [MissingOverride] setClosedOnDate overrides method in SavingsAccount; 
expected @Override
       public void setClosedOnDate(final LocalDate closedOnDate) {
                   ^
   ```     
      


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to