adamsaghy commented on code in PR #4828: URL: https://github.com/apache/fineract/pull/4828#discussion_r2218675432
########## fineract-provider/src/main/resources/db/changelog/tenant/parts/0192_create_loan_approved_amount_history.xml: ########## @@ -0,0 +1,89 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.3.xsd";> + <changeSet author="fineract" id="1" context="postgresql"> + <createTable tableName="m_loan_approved_amount_history"> + <column autoIncrement="true" name="id" type="BIGINT"> + <constraints nullable="false" primaryKey="true" primaryKeyName="pk_m_loan_approved_amount_history"/> + </column> + <column name="loan_id" type="BIGINT"> + <constraints nullable="false"/> + </column> + <column name="new_approved_amount" type="DECIMAL(19, 6)"> + <constraints nullable="false"/> + </column> + <column name="old_approved_amount" type="DECIMAL(19, 6)"> + <constraints nullable="false"/> + </column> + <column name="created_by" type="BIGINT"/> + <column name="created_on_utc" type="timestamp with time zone"/> + <column name="last_modified_by" type="BIGINT"/> + <column name="last_modified_on_utc" type="timestamp with time zone"/> + </createTable> + </changeSet> + <changeSet author="fineract" id="2" context="mysql"> + <createTable tableName="m_loan_approved_amount_history"> + <column autoIncrement="true" name="id" type="BIGINT"> + <constraints nullable="false" primaryKey="true" primaryKeyName="pk_m_loan_approved_amount_history"/> + </column> + <column name="loan_id" type="BIGINT"> + <constraints nullable="false"/> + </column> + <column name="new_approved_amount" type="DECIMAL(19, 6)"> + <constraints nullable="false"/> + </column> + <column name="old_approved_amount" type="DECIMAL(19, 6)"> + <constraints nullable="false"/> + </column> + <column name="created_by" type="BIGINT"/> + <column name="created_on_utc" type="DATETIME"/> + <column name="last_modified_by" type="BIGINT"/> + <column name="last_modified_on_utc" type="DATETIME"/> + </createTable> + </changeSet> + <changeSet author="fineract" id="3"> + <addForeignKeyConstraint baseColumnNames="created_by" baseTableName="m_loan_approved_amount_history" + constraintName="FK_loan_approved_amount_history_created_by" deferrable="false" initiallyDeferred="false" + onDelete="RESTRICT" onUpdate="RESTRICT" referencedColumnNames="id" + referencedTableName="m_appuser" validate="true"/> + <addForeignKeyConstraint baseColumnNames="last_modified_by" baseTableName="m_loan_approved_amount_history" + constraintName="FK_loan_approved_amount_history_last_modified_by" deferrable="false" initiallyDeferred="false" + onDelete="RESTRICT" onUpdate="RESTRICT" referencedColumnNames="id" + referencedTableName="m_appuser" validate="true"/> + <addForeignKeyConstraint baseColumnNames="loan_id" baseTableName="m_loan_approved_amount_history" + constraintName="FK_loan_approved_amount_history_loan_id" deferrable="false" initiallyDeferred="false" + onDelete="RESTRICT" onUpdate="RESTRICT" referencedColumnNames="id" + referencedTableName="m_loan" validate="true"/> + </changeSet> + <changeSet author="fineract" id="4" runInTransaction="false" context="postgresql"> + <sql> + create index concurrently if not exists m_loan_approved_amount_history_idx_1 on m_loan_approved_amount_history(loan_id); Review Comment: We dont need index if the column is already a foreign key! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
