Cocoa-Puffs commented on code in PR #4884:
URL: https://github.com/apache/fineract/pull/4884#discussion_r2239657186
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -1356,7 +1355,8 @@ private void
handleDisbursementWithoutEMICalculator(LoanTransaction disbursement
}
private void handleCapitalizedIncome(LoanTransaction
capitalizedIncomeTransaction, TransactionCtx transactionCtx) {
- if (capitalizedIncomeTransaction.getLoan().isInterestBearing()) {
+ // TODO: Fix this and enhance EMICalculator to support reamortization
and reaging
Review Comment:
In my understanding the scope of the issue was to move away from non EMI
methods as much as possible as part of this ticket. This could not be done
completely in a timely fashion as there were multiple operations that would
need to be included in the emi calculator for everything to work. Reaging,
reamortization, charges. I added the todo so that in the future if we implement
these operations in the emi calculator we can remove the non emi calculator
using method, same as with disbursements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
