Cocoa-Puffs commented on code in PR #4884:
URL: https://github.com/apache/fineract/pull/4884#discussion_r2239681033
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/data/RepaymentPeriod.java:
##########
@@ -84,6 +84,10 @@ public final class RepaymentPeriod {
@Getter
private BigDecimal totalDisbursedAmount;
+ @Setter
+ @Getter
+ private BigDecimal totalCapitalizedIncomeAmount;
Review Comment:
There was a problem specifically with 0% interest loans that have FLAT
interest method, with capitalized income transactions. The method that provides
the principal calculation in these cases is (now called)
`RepaymentPeriod.calculateTotalDisbursedAndCapitalizedIncomeAmountTillGivenPeriod`,
it also calculates the EMI values for flat interest loans in
`ProgressiveEMICalculator.calculateEMIOnActualModelWithFlatInterestMethod`,
previously the calculate method didn't include the capitalized income amounts
in the total and because of this the principal from capitalized income
transactions were not calculated into the EMI. I made it a part of this PR
because the problem arose because the non-emi capitalized income handling
didn't have this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
