adamsaghy commented on code in PR #4885:
URL: https://github.com/apache/fineract/pull/4885#discussion_r2251944637
##########
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccrualBasedAccountingProcessorForSavings.java:
##########
@@ -182,9 +182,17 @@ else if
(savingsTransactionDTO.getTransactionType().isInterestPosting()) {
else if (savingsTransactionDTO.getTransactionType().isAccrual()) {
// Post journal entry for Accrual Recognition
if
(savingsTransactionDTO.getAmount().compareTo(BigDecimal.ZERO) > 0) {
-
this.helper.createCashBasedJournalEntriesAndReversalsForSavings(office,
currencyCode,
-
AccrualAccountsForSavings.INTEREST_ON_SAVINGS.getValue(),
AccrualAccountsForSavings.INTEREST_PAYABLE.getValue(),
- savingsProductId, paymentTypeId, savingsId,
transactionId, transactionDate, amount, isReversal);
+ if (savingsTransactionDTO.getIsOverdraftDown()) {
+
this.helper.createCashBasedJournalEntriesAndReversalsForSavings(office,
currencyCode,
+
AccrualAccountsForSavings.INTEREST_PAYABLE.getValue(),
+
AccrualAccountsForSavings.INTEREST_ON_SAVINGS.getValue(), savingsProductId,
paymentTypeId, savingsId,
+ transactionId, transactionDate, amount,
isReversal);
+ } else {
Review Comment:
This looks incorrect to me as different gl accounts should be used here, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
