adamsaghy commented on code in PR #4885:
URL: https://github.com/apache/fineract/pull/4885#discussion_r2259795150
##########
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccrualBasedAccountingProcessorForSavings.java:
##########
@@ -185,6 +185,11 @@ else if
(savingsTransactionDTO.getTransactionType().isAccrual()) {
this.helper.createCashBasedJournalEntriesAndReversalsForSavings(office,
currencyCode,
AccrualAccountsForSavings.INTEREST_ON_SAVINGS.getValue(),
AccrualAccountsForSavings.INTEREST_PAYABLE.getValue(),
savingsProductId, paymentTypeId, savingsId,
transactionId, transactionDate, amount, isReversal);
+ } else {
+
this.helper.createCashBasedJournalEntriesAndReversalsForSavings(office,
currencyCode,
Review Comment:
Is this accrual based or cash based? if accrual based, please dont use
"createCashBasedJournalEntriesAndReversalsForSaving" method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
