kapil-panchal commented on PR #4902:
URL: https://github.com/apache/fineract/pull/4902#issuecomment-3184234216
> @@ -77,4 +82,22 @@ public CurrencyUpdateResponse
updateCurrencies(CurrencyUpdateRequest request) {
return response.get();
}
+
+ @POST
+ @Consumes({ MediaType.APPLICATION_JSON })
+ @Produces({ MediaType.APPLICATION_JSON })
+ @Operation(summary = "Create a new currency", description = "Adds
a new currency to the platform with the given code, name, symbol,
decimal places, in multiples of and name code.")
+ public CurrencyCreateResponse ***@***.***
CurrencyCreateRequest request) {
+ final CurrencyCreateCommand command = new CurrencyCreateCommand();
+
+ request.setNameCode("currency." + request.getCode());
We dont need this. please remove.
So for this, shall I allow the user to add the nameCode e.g.
"currency.AAA" and validate the field explicitly?
On Wed, Aug 13, 2025 at 8:11 PM Adam Saghy ***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In
>
fineract-core/src/main/java/org/apache/fineract/organisation/monetary/api/CurrenciesApiResource.java
> <https://github.com/apache/fineract/pull/4902#discussion_r2273688370>:
>
> > @@ -77,4 +82,22 @@ public CurrencyUpdateResponse
updateCurrencies(CurrencyUpdateRequest request) {
>
> return response.get();
> }
> +
> + @POST
> + @Consumes({ MediaType.APPLICATION_JSON })
> + @Produces({ MediaType.APPLICATION_JSON })
> + @Operation(summary = "Create a new currency", description = "Adds a
new currency to the platform with the given code, name, symbol, decimal places,
in multiples of and name code.")
> + public CurrencyCreateResponse ***@***.*** CurrencyCreateRequest
request) {
> + final CurrencyCreateCommand command = new CurrencyCreateCommand();
> +
> + request.setNameCode("currency." + request.getCode());
>
> We dont need this. please remove.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/4902#discussion_r2273688370>, or
> unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/ATFEJGAINABR4CXLLR2ZMMD3NNFBJAVCNFSM6AAAAACCTG6XLWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCMJWGM2TMOJUGQ>
> .
> You are receiving this because you modified the open/close state.Message
> ID: ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
