adamsaghy commented on PR #4902:
URL: https://github.com/apache/fineract/pull/4902#issuecomment-3184244882
> @@ -77,4 +82,22 @@ public CurrencyUpdateResponse
updateCurrencies(CurrencyUpdateRequest request) {
> return response.get(); } + + @post + @consumes({
MediaType.APPLICATION_JSON }) + @produces({ MediaType.APPLICATION_JSON }) +
@operation(summary = "Create a new currency", description = "Adds a new
currency to the platform with the given code, name, symbol, decimal places, in
multiples of and name code.") + public CurrencyCreateResponse ***@***.***
CurrencyCreateRequest request) { + final CurrencyCreateCommand command = new
CurrencyCreateCommand(); + + request.setNameCode("currency." +
request.getCode()); We dont need this. please remove. So for this, shall I
allow the user to add the nameCode e.g. "currency.AAA" and validate the field
explicitly?
> […](#)
> On Wed, Aug 13, 2025 at 8:11 PM Adam Saghy ***@***.***> wrote:
***@***.**** commented on this pull request. ------------------------------ In
fineract-core/src/main/java/org/apache/fineract/organisation/monetary/api/CurrenciesApiResource.java
<[#4902
(comment)](https://github.com/apache/fineract/pull/4902#discussion_r2273688370)>:
> @@ -77,4 +82,22 @@ public CurrencyUpdateResponse
updateCurrencies(CurrencyUpdateRequest request) { return response.get(); } + +
@post + @consumes({ MediaType.APPLICATION_JSON }) + @produces({
MediaType.APPLICATION_JSON }) + @operation(summary = "Create a new currency",
description = "Adds a new currency to the platform with the given code, name,
symbol, decimal places, in multiples of and name code.") + public
CurrencyCreateResponse ***@***.*** CurrencyCreateRequest request) { + final
CurrencyCreateCommand command = new CurrencyCreateCommand(); + +
request.setNameCode("currency." + request.getCode()); We dont need this. please
remove. — Reply to
this email directly, view it on GitHub <[#4902
(comment)](https://github.com/apache/fineract/pull/4902#discussion_r2273688370)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATFEJGAINABR4CXLLR2ZMMD3NNFBJAVCNFSM6AAAAACCTG6XLWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCMJWGM2TMOJUGQ>
. You are receiving this because you modified the open/close state.Message ID:
***@***.***>
I dont think customer should provide this field... fineract calculates
automatically once it got saved? All i am saying, I dont wanna see modification
of the incoming request for this. Just before you save it you can calculate and
save it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
