JohnAlva commented on code in PR #4886:
URL: https://github.com/apache/fineract/pull/4886#discussion_r2278191758
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsAccountInterestPostingServiceImpl.java:
##########
@@ -268,16 +271,66 @@ public List<PostingPeriod> calculateInterestUsing(final
MathContext mc, final Lo
if
(postedAsOnDates.contains(periodInterval.endDate().plusDays(1))) {
isUserPosting = true;
}
- final PostingPeriod postingPeriod =
PostingPeriod.createFromDTO(periodInterval, periodStartingBalance,
-
retreiveOrderedNonInterestPostingTransactions(savingsAccountData),
monetaryCurrency, compoundingPeriodType,
- interestCalculationType, interestRateAsFraction,
daysInYearType.getValue(), upToInterestCalculationDate,
- interestPostTransactions, isInterestTransfer,
minBalanceForInterestCalculation,
- isSavingsInterestPostingAtCurrentPeriodEnd,
overdraftInterestRateAsFraction, minOverdraftForInterestCalculation,
- isUserPosting, financialYearBeginningMonth,
savingsAccountData.isAllowOverdraft());
+ if (savingsAccountData.isAllowOverdraft() &&
!MathUtil.isZero(savingsAccountData.getGlAccountIdForInterestReceivable())) {
+
+ List<SavingsAccountTransactionData>
overdraftTransactionsInPeriod = listForOverdraft(savingsAccountData,
periodInterval);
+ List<SavingsAccountTransactionData>
interestPostingTransactionsInPeriod = listForInterestPosting(savingsAccountData,
+ periodInterval);
+ Boolean isOverdraftAccountType =
isOverdraftAccount(savingsAccountData, periodInterval);
+ List<SavingsAccountTransactionData> prioritizedTransactionList
= null;
Review Comment:
I renamed the variables to explicitly reflect the type of transactions they
contain. OverdraftTransactionsForPeriod now stores overdraft transactions, and
InterestTransactionsForPeriod stores interest transactions for the period,
making the code more readable and self-explanatory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
