JohnAlva commented on code in PR #4886:
URL: https://github.com/apache/fineract/pull/4886#discussion_r2279409586


##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/domain/interest/PostingPeriod.java:
##########
@@ -64,6 +65,8 @@ public final class PostingPeriod {
 
     private Integer financialYearBeginningMonth;
 
+    private Boolean isEndTransaction = false;

Review Comment:
   The isEndTransaction (boolean) parameter was removed because it was no 
longer needed in the current logic. Validation that relied on it is now 
directly covered by the date conditions already present in the method, so there 
was no need to replace it with a date field.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to