adamsaghy commented on code in PR #4876:
URL: https://github.com/apache/fineract/pull/4876#discussion_r2278885437
##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingHelper.java:
##########
@@ -71,7 +71,7 @@ public class ProductToGLAccountMappingHelper {
public void saveProductToAccountMapping(final JsonElement element, final
String paramName, final Long productId,
final int placeHolderTypeId, final GLAccountType
expectedAccountType, final PortfolioProductType portfolioProductType) {
final Long accountId =
this.fromApiJsonHelper.extractLongNamed(paramName, element);
- if (accountId != null) { // optional entries may be null
+ if (accountId != null && accountId > 0) { // optional entries may be
null
Review Comment:
Please remove this nonsense `accountId > 0`....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
