adamsaghy commented on code in PR #4876:
URL: https://github.com/apache/fineract/pull/4876#discussion_r2278886341
##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingHelper.java:
##########
@@ -111,11 +112,15 @@ public void mergeProductToAccountMappingChanges(final
JsonElement element, final
throw new
ProductToGLAccountMappingNotFoundException(portfolioProductType, productId,
accountTypeName);
}
} else {
- if (accountMapping.getGlAccount() != null &&
!Objects.equals(accountMapping.getGlAccount().getId(), accountId)) {
+ if (accountMapping.getGlAccount() != null && accountId > 0
Review Comment:
Please remove this nonsense accountId > 0....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
