adamsaghy commented on code in PR #4886:
URL: https://github.com/apache/fineract/pull/4886#discussion_r2306717269
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsAccountInterestPostingServiceImpl.java:
##########
@@ -500,7 +606,7 @@ protected SavingsAccountTransactionData
findInterestPostingTransactionFor(final
SavingsAccountTransactionData postingTransation = null;
List<SavingsAccountTransactionData> trans =
savingsAccountData.getSavingsAccountTransactionData();
for (final SavingsAccountTransactionData transaction : trans) {
- if ((transaction.isInterestPostingAndNotReversed() ||
transaction.isOverdraftInterestAndNotReversed())
+ if ((transaction.isInterestPostingAndNotReversed() &&
transaction.isOverdraftInterestAndNotReversed())
Review Comment:
@JohnAlva I have executed the `SavingsInterestPostingTest` when
`if ((transaction.isInterestPostingAndNotReversed() ||
transaction.isOverdraftInterestAndNotReversed())`
and also when
`if ((transaction.isInterestPostingAndNotReversed() &&
transaction.isOverdraftInterestAndNotReversed())`.
In both cases all tests were GREEN, which is not good! Please make sure you
have tests (integration or unit) which ensures it works correctly!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
