JohnAlva commented on code in PR #4886:
URL: https://github.com/apache/fineract/pull/4886#discussion_r2305352579
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsAccountInterestPostingServiceImpl.java:
##########
@@ -500,7 +606,7 @@ protected SavingsAccountTransactionData
findInterestPostingTransactionFor(final
SavingsAccountTransactionData postingTransation = null;
List<SavingsAccountTransactionData> trans =
savingsAccountData.getSavingsAccountTransactionData();
for (final SavingsAccountTransactionData transaction : trans) {
- if ((transaction.isInterestPostingAndNotReversed() ||
transaction.isOverdraftInterestAndNotReversed())
+ if ((transaction.isInterestPostingAndNotReversed() &&
transaction.isOverdraftInterestAndNotReversed())
Review Comment:
Also added/adjusted tests in SavingsInterestPostingTest to cover
interest-only, overdraft-only, and mixed scenarios, and fixed the compounding
setup in SavingsProductHelper for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
