adamsaghy commented on code in PR #5294:
URL: https://github.com/apache/fineract/pull/5294#discussion_r2682180892
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -1574,6 +1574,10 @@ private void
handleDisbursementWithEMICalculator(LoanTransaction disbursementTra
Money amortizableAmount =
disbursementTransaction.getAmount(currency).minus(downPaymentAmount);
emiCalculator.addDisbursement(model, transactionDate,
amortizableAmount);
+ if (loan.isAllowFullTermForTranche() && loan.getNumberOfRepayments() >
0) {
Review Comment:
We are already updating the installments by model as part of
`recalculateRepaymentPeriodsWithEMICalculation`. Do we really need to do it
again here?
One of them should be removed, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
