mariiaKraievska commented on code in PR #5294:
URL: https://github.com/apache/fineract/pull/5294#discussion_r2686162049


##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -1595,6 +1599,41 @@ private void 
handleDisbursementWithEMICalculator(LoanTransaction disbursementTra
         allocateOverpayment(disbursementTransaction, transactionCtx);
     }
 
+    private void updateInstallmentsByModel(final LoanTransaction 
loanTransaction, final ProgressiveTransactionCtx ctx) {

Review Comment:
   Removed updateInstallmentsByModel



##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/data/RepaymentPeriod.java:
##########
@@ -360,6 +360,9 @@ public Money getCreditedAmounts() {
     public Money getOutstandingLoanBalance() {
         if (outstandingBalanceCalculation == null) {
             outstandingBalanceCalculation = Memo.of(() -> {
+                if (getInterestPeriods().isEmpty()) {
+                    return getZero();

Review Comment:
   Removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to