adamsaghy commented on code in PR #5367:
URL: https://github.com/apache/fineract/pull/5367#discussion_r2721116578
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/configuration/api/GlobalConfigurationConstants.java:
##########
@@ -79,6 +79,7 @@ public final class GlobalConfigurationConstants {
public static final String
ASSET_OWNER_TRANSFER_OUTSTANDING_INTEREST_CALCULATION_STRATEGY =
"outstanding-interest-calculation-strategy-for-external-asset-transfer";
public static final String
ALLOWED_LOAN_STATUSES_FOR_EXTERNAL_ASSET_TRANSFER =
"allowed-loan-statuses-for-external-asset-transfer";
public static final String
ALLOWED_LOAN_STATUSES_OF_DELAYED_SETTLEMENT_FOR_EXTERNAL_ASSET_TRANSFER =
"allowed-loan-statuses-of-delayed-settlement-for-external-asset-transfer";
+ public static final String RESTRICT_REUSE_OF_PASSWORD =
"restrict-reuse-of-password";
Review Comment:
I dont like the naming. This global configuration serves a dual purpose:
- whether we want to restrict password reusage
- For the N last used password to be checked.
Can you please use something which fit better for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
