adamsaghy commented on code in PR #5367: URL: https://github.com/apache/fineract/pull/5367#discussion_r2721125092
########## fineract-provider/src/main/resources/db/changelog/tenant/parts/0208_add_configuration_restrict_reuse_of_password.xml: ########## @@ -0,0 +1,35 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.1.xsd";> + <changeSet author="fineract" id="1"> + <insert tableName="c_configuration"> + <column name="name" value="restrict-reuse-of-password"/> + <column name="value" valueNumeric="3"/> + <column name="date_value"/> + <column name="string_value"/> + <column name="enabled" valueBoolean="false"/> + <column name="is_trap_door" valueBoolean="false"/> + <column name="description" value="Number of previous passwords to check when a user changes their password. Set to 0 or disable to allow password reuse."/> Review Comment: `Set to 0 or disable to allow password reuse.` i dont like this. If it is enabled, it should prevent password reusage! Having it enabled and value = 0 should not "allow password reuse" but instead do not allow any reused password! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
