Shivd131 commented on PR #5348: URL: https://github.com/apache/fineract/pull/5348#issuecomment-3795970361
@adamsaghy Thanks for the detailed review. I have refactored the PR to align with your feedback: - Reverted application.properties - Switched to @Timed: Removed the manual Timer boilerplate from the resource file. I added a small MetricsConfig class to enable the TimedAspect bean so the annotation works correctly with Jersey. - Context on the original approach: The reason I initially used manual instrumentation was to capture dynamic tags like reportName and outputType. For my future projects, determining exactly which specific reports are resource-intensive is crucial for deciding what to offload to a microservice. The current @Timed implementation aggregates all reports into one metric, which hides that granularity, but I agree this is the cleaner, standard starting point for the codebase. I am open to any suggestions/corrections if required -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
