adamsaghy commented on code in PR #5348:
URL: https://github.com/apache/fineract/pull/5348#discussion_r2727507067
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/config/MetricsConfig.java:
##########
@@ -16,15 +16,21 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.fineract.portfolio.loanorigination.config;
-import org.apache.fineract.infrastructure.core.condition.PropertiesCondition;
-import org.apache.fineract.infrastructure.core.config.FineractProperties;
+package org.apache.fineract.infrastructure.core.config;
-public class LoanOriginationModuleIsEnabledCondition extends
PropertiesCondition {
+import io.micrometer.core.aop.TimedAspect;
+import io.micrometer.core.instrument.MeterRegistry;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+import org.springframework.context.annotation.EnableAspectJAutoProxy;
- @Override
- protected boolean matches(FineractProperties properties) {
- return properties.getModule().getLoanOrigination().isEnabled();
+@Configuration
+@EnableAspectJAutoProxy
+public class MetricsConfig {
+
+ @Bean
+ public TimedAspect timedAspect(MeterRegistry registry) {
+ return new TimedAspect(registry);
}
}
Review Comment:
Are you sure we need this configuration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
