Monica-CodingWorld commented on PR #5362: URL: https://github.com/apache/fineract/pull/5362#issuecomment-3798077438
Hi @Aman-Mittal, I've addressed all your feedback: - Extracted helper methods - isAmountRequired() and isRecurrenceRequired() to eliminate code duplication - Added JavaDoc - Explaining business rules clearly - Added unit tests - 8 tests covering all scenarios (amount/recurrence requirements for both DUES and FIXED_AMOUNT_TRANSFER types) All tests pass locally. Please review the changes. Once you approve, I'll squash the commits into a single clean commit before merging. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
