Aman-Mittal commented on PR #5362: URL: https://github.com/apache/fineract/pull/5362#issuecomment-3805439466
Yes I think it should be like this. Well these things should be updated and clarified in the ticket itself. In case of usecase there can be partial input also. I think based on requirement if user didn't pass these values then fetched from loan repayment schedule. If there is no such field available then we may force user to input. You should also clarify this on ticket too. The orignal reporter and someone who is knowledgeable in functional side can answer you more clearly. On Tue, 27 Jan, 2026, 7:30 pm Monica, ***@***.***> wrote: > *Monica-CodingWorld* left a comment (apache/fineract#5362) > <https://github.com/apache/fineract/pull/5362#issuecomment-3805370608> > > @Monica-CodingWorld <https://github.com/Monica-CodingWorld> - Take a look > at the ticket and understand usecase first > > When standing instruction type selected is "dues", the following fields > should be optional since they will be picked from the loan repayment > schedule: > > amount, interval, recurrence frequency, on month day > > Before the requirement im assuming that e2e tests have covered the if all > fields have the value (this may be the use case where we are trying to > update the loan repayment schedule itself // need to check the code) > > Now you can add cases for following scenarios eg. lets assume user does > not pass any of the values then what should happen? Ans. missing value > should be fetched from the loan repayment schedule > > Open end questions and things need to be checked (what is the existing > implementation can you make sense to a non tech person) > > test case 1 -> amount, (inputted) interval,(blank from user) recurrence > frequency, (blank from user) on month day , blank from user > > test case 2 -> amount, (inputted) interval,(inputted) recurrence > frequency, (blank from user) on month day , blank from user > > and so on > > @adamsaghy <https://github.com/adamsaghy> Please correct me if i missed > something, im just assuming things as example based on what ticket is saying > > Thanks @Aman-Mittal <https://github.com/Aman-Mittal> for the detailed > scenarios. This is my first unit test, so I want to make sure I understand > the requirement correctly before rewriting. > Confirming the logic: When type="dues", if the user provides some of the > four fields (amount, interval, recurrence frequency, onMonthDay) but leaves > others blank, the system should: > Use the user-provided values as-is, and > Fetch only the missing values from the loan repayment schedule? > Or should it be strictly all-or-nothing (either user provides all four, or > system fetches all four from schedule)? > Error handling: If the loan repayment schedule doesn't have these values > available, should the validator: > Fail fast with a validation error here, or > Pass through and let downstream service handle the missing data exception? > I'll check the existing implementation to see if this fallback logic is > already in place or needs to be built. Let me know if there's existing test > coverage I should reference for the "fetch from schedule" behavior. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/fineract/pull/5362#issuecomment-3805370608>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AHV6TA67T256D32AMHMMI7L4I5VORAVCNFSM6AAAAACSN7B7YOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQMBVGM3TANRQHA> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
