adamsaghy commented on code in PR #5436:
URL: https://github.com/apache/fineract/pull/5436#discussion_r2759919896
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/event/external/api/ExternalEventConfigurationApiResource.java:
##########
@@ -61,13 +58,10 @@ public ExternalEventConfigurationResponse
getExternalEventConfigurations() {
@Consumes({ MediaType.APPLICATION_JSON })
@Produces({ MediaType.APPLICATION_JSON })
@Operation(summary = "Enable/Disable external events posting", description
= "")
- public ExternalEventConfigurationUpdateResponse
updateExternalEventConfigurations(@HeaderParam("Idempotency-Key") String
idempotencyKey,
+ public ExternalEventConfigurationUpdateResponse
updateExternalEventConfigurations(
@Valid ExternalEventConfigurationUpdateRequest request) {
final var command = new ExternalConfigurationsUpdateCommand();
- command.setId(UUID.randomUUID());
- command.setIdempotencyKey(idempotencyKey);
Review Comment:
Who will set the idempotency key?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
