adamsaghy commented on code in PR #5436:
URL: https://github.com/apache/fineract/pull/5436#discussion_r2763056766
##########
fineract-command/src/main/java/org/apache/fineract/command/core/Command.java:
##########
@@ -32,11 +31,11 @@ public class Command<T> implements Serializable {
@Serial
private static final long serialVersionUID = 1L;
- private UUID id;
-
private String idempotencyKey;
- private OffsetDateTime createdAt;
+ private String ipAddress;
+
+ private Instant createdAt;
Review Comment:
Minor:
We havent really used `Instant` anywhere so far... I understand for audit
times it could also work, but it would be nice to use just one of them...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
