adamsaghy commented on code in PR #5436:
URL: https://github.com/apache/fineract/pull/5436#discussion_r2763093233


##########
fineract-command/src/main/resources/db/changelog/tenant/module/command/parts/0001_command_init_postgres.xml:
##########
@@ -22,28 +22,20 @@
 <databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog";
                    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
                    
xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog 
http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.1.xsd";>
-    <changeSet author="fineract" id="command-00001" context="postgresql">
+    <changeSet author="fineract" id="command-00001" context="postgresql" 
failOnError="false">
         <createTable tableName="m_command">
             <column autoIncrement="true" name="id" type="bigint" 
remarks="Internal ID">
                 <constraints nullable="false" primaryKey="true"/>
             </column>
-            <column name="created_at" type="timestamp with time zone" />
-            <column name="command_id" type="uuid" />
+            <column name="created_at" type="timestamp" />

Review Comment:
   Please dont use timestamp, use timestamp with TZ as we did everywhere!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to