Aman-Mittal commented on code in PR #5465:
URL: https://github.com/apache/fineract/pull/5465#discussion_r2780497930
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/SavingsAccountTransactionsApiResource.java:
##########
@@ -193,6 +193,9 @@ public String transaction(@PathParam("savingsId") final
Long savingsId, @QueryPa
} else if (is(commandParam, "withdrawal")) {
final CommandWrapper commandRequest =
builder.savingsAccountWithdrawal(savingsId).build();
result =
this.commandsSourceWritePlatformService.logCommandSource(commandRequest);
+ } else if (is(commandParam, "force-withdrawal")) {
Review Comment:
This else if is becoming too long i think we can optimise this further
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/savings/SavingsAccountHelper.java:
##########
@@ -1114,7 +1203,8 @@ public HashMap getSavingsDetails(final Integer savingsID)
{
}
// TODO: Rewrite to use fineract-client instead!
- // Example:
org.apache.fineract.integrationtests.common.loans.LoanTransactionHelper.disburseLoan(java.lang.Long,
+ // Example:
+ //
org.apache.fineract.integrationtests.common.loans.LoanTransactionHelper.disburseLoan(java.lang.Long,
Review Comment:
This is bringing too much noise in review this comment part can be reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
